Code migration texas #102
Open
Code migration texas #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils/transform/Form.py
Outdated
|
|
||
|
|
||
| class ExpenseForm(Form): | ||
| def __init__(self, column_mapper=None): |
There was a problem hiding this comment.
This would need different 'read_table' for some states. To deal with this, you can make state specific subclasses. This class should be considered the most common/standard Expense form.
Make sure you add a docstring to the class that describes that
src/utils/transform/Form.py
Outdated
| pass | ||
|
|
||
| def map_columns(self) -> None: | ||
| """Map and filter columns of the DataFrame""" |
There was a problem hiding this comment.
add a bit more explanation to this
| self.table = None | ||
|
|
||
| @abc.abstractmethod | ||
| def read_table(self, paths: list[str]) -> pd.DataFrame: |
There was a problem hiding this comment.
google style docstring, describe 'paths'
src/utils/transform/Form.py
Outdated
| def __init__(self, column_mapper=None): | ||
| required_columns = [ | ||
| "DONOR_ID", | ||
| "RECIPIENT", |
There was a problem hiding this comment.
RECIPIENT_ID
Created Form subclasses for normalized and semi-normalized form tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.